Skip to content

RE1-T121 Fixing back dockerfile base#398

Merged
ucswift merged 1 commit into
masterfrom
develop
Jun 5, 2026
Merged

RE1-T121 Fixing back dockerfile base#398
ucswift merged 1 commit into
masterfrom
develop

Conversation

@ucswift

@ucswift ucswift commented Jun 5, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated base runtime images for Eventing, MCP, Services, and TTS services to enhance compatibility and performance.

@request-info

request-info Bot commented Jun 5, 2026

Copy link
Copy Markdown

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

@coderabbitai

coderabbitai Bot commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Complex PR? Review this PR in Change Stack to move by importance, not file order.

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9cb322dc-ac98-4282-8f4f-bd9c056b25f8

📥 Commits

Reviewing files that changed from the base of the PR and between 57efed6 and c394ddd.

📒 Files selected for processing (4)
  • Web/Resgrid.Web.Eventing/Dockerfile
  • Web/Resgrid.Web.Mcp/Dockerfile
  • Web/Resgrid.Web.Services/Dockerfile
  • Web/Resgrid.Web.Tts/Dockerfile
📝 Walkthrough

Walkthrough

This PR updates four web service Dockerfiles to switch their base container image from dhi.io/dotnet:9.0.16 to dhi.io/aspnetcore:9.0.16, with updated SHA256 digests. The multi-stage build structure (build, publish, final stages) remains unchanged across all services.

Changes

Docker base image update to aspnetcore

Layer / File(s) Summary
Docker base image reference update across web services
Web/Resgrid.Web.Eventing/Dockerfile, Web/Resgrid.Web.Mcp/Dockerfile, Web/Resgrid.Web.Services/Dockerfile, Web/Resgrid.Web.Tts/Dockerfile		 Base stage images are updated from dhi.io/dotnet:9.0.16 to dhi.io/aspnetcore:9.0.16 with new pinned digests; all build, publish, and final stages remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Resgrid/Core#380: Both PRs modify the same Web service Dockerfiles' base stage image references (switching to dhi.io-hardened ASP.NET/dotnet runtime images), so the main PR's digest/namespace updates are directly related to #380's Docker hardening changes.
  • Resgrid/Core#340: Both PRs modify Web/Resgrid.Web.Tts/Dockerfile's base stage image reference (changing the .NET base runtime used in the container), so the Docker build/runtime base setup overlaps.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'RE1-T121 Fixing back dockerfile base' is partially related to the changeset but lacks clarity and specificity about the actual changes made. Consider a more descriptive title that clarifies what 'fixing back' means, such as 'Update Docker base images from dotnet to aspnetcore 9.0.16' or 'Switch Docker base images to aspnetcore runtime'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ucswift

ucswift commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

Approve

github-actions[bot]
github-actions Bot approved these changes Jun 5, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift ucswift merged commit e905a1e into master Jun 5, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ucswift